-
Notifications
You must be signed in to change notification settings - Fork 0
Redis cluster support #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace hardcoded ASDF Python paths with dynamic discovery - Support Python versions 3.9-3.14 across multiple installation methods - Exclude venv/.venv directories and config/gdb files from search - Select latest version when multiple interpreters of same major version found - Fix import structure in gate.py to resolve linting issues - Add non-interactive flag to mypy to prevent hanging on missing types
- Add three Redis cluster nodes (ports 7001-7003) with cluster mode enabled - Include cluster initialization service to automatically create cluster - Maintain backward compatibility with single Redis instance (port 6379) - Add proper health checks for all Redis services - Enable appendonly persistence for cluster nodes
- Add RedisConfig and RedisClusterConfig typed configuration classes - Update RedisStorage to support both single Redis and cluster connections - Add redis_config parameter to CallGate constructor with type hints - Update RedisReentrantLock to work with both Redis and RedisCluster - Maintain full backward compatibility with existing kwargs approach - Add comprehensive documentation for new typed Redis parameters
- Fix duplicate [testenv:py313] section, rename second one to [testenv:py314] - Resolve configuration parsing error that prevented pytest from running
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
- Coverage 98.38% 98.14% -0.25%
==========================================
Files 7 7
Lines 682 807 +125
Branches 73 100 +27
==========================================
+ Hits 671 792 +121
- Misses 4 7 +3
- Partials 7 8 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Modified ClusterManager to detect GitHub Actions environment - Skip Docker container management in GitHub Actions (uses systemctl) - Skip fault tolerance tests in CI (require container management) - Removed 'not cluster' marker from CI workflow to enable cluster tests - ClusterManager now uses redis-cluster-service nodes (7000-7005) in CI - All container start/stop operations are no-ops in GitHub Actions
- Bump coverage to version 7.13.0 - Update platformdirs to version 4.5.1 - Upgrade pytest to version 9.0.2 - Update ssort to version 0.16.0 - Upgrade urllib3 to version 2.6.1 - Add new version of roman package (5.2) for Python 3.10 - Enhance RedisStorage with explicit close method and destructor - Modify GitHub Actions workflow to include verbose output for pytest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
redis_clientparameter accepts pre-initializedRedisorRedisClusterclientsCallGateRedisConfigurationErrorfor Redis configuration issuesChanged
Deprecated
**kwargsis deprecated and will be removed in version 2.0.0redis_clientparameter with pre-initialized clientsFixed